pivot-user mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Edvin Syse <ed...@sysedata.no>
Subject Re: Update TabData - supposed to call listeners manually?
Date Tue, 14 Jun 2011 21:02:18 GMT
Den 14.06.2011 22:56, skrev Edvin Syse:
>
>
> Den 14.06.2011 22:49, skrev Roger L. Whitcomb:
>> Maybe TabPane should be testing:
>> if (!previousTabData.equals(tabData))
>> instead of using "=="??
>>
>
> It would have to do null-checks, or switch to if
> (!tabData.equals(previousTabData)), but even then, ButtonData would need
> an equals() method. If the equals() method checked the text and userData
> properties (and skip the Image) that would work :)

.. or maybe it should be the caller's responsibility to check, and only 
call setTabData if you actually either change the tabData object or one 
of it's properties? :) I don't know enough about Pivot internals to mean 
anything about the ramifications, though.

Mime
View raw message