Mailing-List: contact dev-help@pivot.apache.org; run by ezmlm
Precedence: bulk
Reply-To: dev@pivot.apache.org
Date: Tue, 24 Apr 2012 17:05:35 +0000 (UTC)
From: "Brendan (JIRA)" <jira@apache.org>
To: dev@pivot.apache.org
Message-ID: 
 <200786995.10297.1335287135303.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1356401280.32035.1332178297825.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (PIVOT-844) SuggestionPopup Allow replacing
 selected text to the beginning index until current cursor of TextInput or
 TextArea Component
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/PIVOT-844?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13260711#comment-13260711 ] 

Brendan commented on PIVOT-844:
-------------------------------

I didn't see you make use of the parameter "characterPosition" in suggestionPopup.java and it seems you do the replacement from the SuggestionPopup Close listener in the test.java.  For this, I can see the effect took a while to process.
I think you should handle the replacement from the SuggestionPopup skin.  So that, setAppendMode and related code are removed, because it is not necessary.


> SuggestionPopup Allow replacing selected text to the beginning index until current cursor of TextInput or TextArea Component 
> -----------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIVOT-844
>                 URL: https://issues.apache.org/jira/browse/PIVOT-844
>             Project: Pivot
>          Issue Type: Improvement
>          Components: wtk, wtk-terra
>            Reporter: Brendan
>            Assignee: Sandro Martini
>            Priority: Minor
>             Fix For: 2.1
>
>         Attachments: PIVOT-844_second_rough_version.patch, PIVOT-844_third_rough_version.patch
>
>   Original Estimate: 96h
>  Remaining Estimate: 96h
>
> SuggestionPopup used to replacing whole content of TextInput once user make a selection.  This creates difficulties in implementing, for example, a list of comma separated email addresses in recipients column. 
>  I suggest to modify the replacing methodology to allow additional parameter of Index of the beginning word to input so that the SuggestionPopup will replace from the beginning index to the current caret (text cursor) with user selection.  Additionally, allow not only TextInput but also TextArea to be served with, which we can build a typing assistant like function.
> The finding the beginning index is user code responsibility which opens up the choice of usages, like email address assistant where ";" is the separator and space as separator when general typing assistant.  The user code just need to use Java String Split to locate the closet word to the caret for SuggestionPopup. 

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira