pivot-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Sandro Martini <sandro.mart...@gmail.com>
Subject Re: [jira] [Commented] (PIVOT-737) TerraTableViewSkin opens a TableViewRowEditor listening to both mouse buttons
Date Wed, 04 May 2011 16:29:38 GMT
Hi Greg,

>> Only a last thing, sorry, just to close the point:
>> even if I set the enables status of the Menu.Item to false, is it right
>> that
>> in the perform(Component source) , source is the Menu.Item, but as
>> inspected
>> by the debugger it has enabled = true  ?
>
>Yes, because the code does not allow you to change the value to false (it
throws an exception).
Yes, I agree with you, but so there is only a corner case where that
exception is not thrown if I call the setEnabled(false) just before the
setAction() ... so if possible I'd like a runtime exception even in this
case.

>
>> If yes, I still have to ask to you only a last thing on this (long)
>> ticket
>> ... on what to do on selection with right click (as written in the jira
>> issue) ... comments ?
>
>You checked in a fix the other day to prevent selection unless the left
mouse button is clicked, correct?
Yes, or better, the editor (for tables, lists, tress) now will be opened
only at (double) Left click.

>This resolved Raffaele's issue, but it brings up an interesting question:
assuming that the user wants to >bring up a context menu in this case,
should a right click change the selection or leave it as-is?
Yes, this is the interesting part I'd like to discuss with all (and of
course with you :-) ), because in the current implementation I see a
Mac-like behavior.
Yesterday I've done some tests on Ubuntu 10.x and I see the same behavior as
Pivot:
right clicking on a row will select it (if it's selectable of course), 
but in Ubuntu if there is a contextual menu it will be opened, while I don't
know in Pivot if we open the popup if present.
>
>On the Mac, right-clicking an item is a bit strange. If I have item "A"
selected and I right click on "B", "A" >remains selected, but "B" gets a
blue outline indicating that it is "sort of" selected. If I select an item
>from the context menu that appears, the selected action applies to "B", not
"A". This actually seems kind >of strange to me. As a user, I think I'd
expect the right click to bring up a menu only, not change the >selection.
But I'm curious to know what others think.
>
So my proposal to add a style to enable/disable selections even on right
click (maybe with default enabled, like the current behavior, but for anyone
not wanting it like in Raffaele case could be used to disable it), could be
simpler and targeted to 2.0.1, while a more complex solution could go in the
2.1 (and in another jira ticket), ok ?

Thanks for your today's comments, I'll wait for others tomorrow :-) .

Bye



--
View this message in context: http://apache-pivot-developers.417237.n3.nabble.com/jira-Created-PIVOT-737-TerraTableViewSkin-opens-a-TableViewRowEditor-listening-to-both-mouse-buttons-tp2871532p2899531.html
Sent from the Apache Pivot - Developers mailing list archive at Nabble.com.

Mime
View raw message