Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id E2223200BBE for ; Thu, 27 Oct 2016 16:34:01 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id E0BC2160AE4; Thu, 27 Oct 2016 14:34:01 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 36803160AF6 for ; Thu, 27 Oct 2016 16:34:01 +0200 (CEST) Received: (qmail 99541 invoked by uid 500); 27 Oct 2016 14:34:00 -0000 Mailing-List: contact commits-help@pirk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pirk.incubator.apache.org Delivered-To: mailing list commits@pirk.incubator.apache.org Received: (qmail 99532 invoked by uid 99); 27 Oct 2016 14:34:00 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd4-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 14:34:00 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd4-us-west.apache.org (ASF Mail Server at spamd4-us-west.apache.org) with ESMTP id 0D2D2C00E7 for ; Thu, 27 Oct 2016 14:34:00 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd4-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -6.219 X-Spam-Level: X-Spam-Status: No, score=-6.219 tagged_above=-999 required=6.31 tests=[KAM_ASCII_DIVIDERS=0.8, KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-2.999] autolearn=disabled Received: from mx1-lw-us.apache.org ([10.40.0.8]) by localhost (spamd4-us-west.apache.org [10.40.0.11]) (amavisd-new, port 10024) with ESMTP id jKiQwSAyaLiH for ; Thu, 27 Oct 2016 14:33:59 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-us.apache.org (ASF Mail Server at mx1-lw-us.apache.org) with SMTP id D98E15FB0B for ; Thu, 27 Oct 2016 14:33:58 +0000 (UTC) Received: (qmail 99290 invoked by uid 99); 27 Oct 2016 14:33:58 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 27 Oct 2016 14:33:58 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id 600142C014E for ; Thu, 27 Oct 2016 14:33:58 +0000 (UTC) Date: Thu, 27 Oct 2016 14:33:58 +0000 (UTC) From: "ASF GitHub Bot (JIRA)" To: commits@pirk.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PIRK-78) Create a new QuerySchema builder to separate from representation MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Thu, 27 Oct 2016 14:34:02 -0000 [ https://issues.apache.org/jira/browse/PIRK-78?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15612059#comment-15612059 ] ASF GitHub Bot commented on PIRK-78: ------------------------------------ Github user tellison commented on the issue: https://github.com/apache/incubator-pirk/pull/112 The local tests, and my travis-ci instance passes the tests ok. I see the failure is caused by a Maven PluginExecutionException. I will push new changes to force a re-test. > Create a new QuerySchema builder to separate from representation > ---------------------------------------------------------------- > > Key: PIRK-78 > URL: https://issues.apache.org/jira/browse/PIRK-78 > Project: PIRK > Issue Type: Improvement > Reporter: Tim Ellison > Assignee: Ellison Anne Williams > Fix For: 0.3.0 > > > Presently, Pirk has a QuerySchemaLoader that reads an XML formatted stream and builds a new QuerySchema. > In order to separate the representation of the schema in XML from the logic of assembling a new schema such as validating the values, a new QuerySchemaBuilder is to be introduced. The QuerySchemaLoader will then delegate the creation to the new builder, and other representations can also use the builder to create a new QuerySchema without having to go via XML. -- This message was sent by Atlassian JIRA (v6.3.4#6332)