pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-79) Allow json serialization to deserialize a queryInfo object that has only the name of a query schema.
Date Mon, 31 Oct 2016 05:12:58 GMT

    [ https://issues.apache.org/jira/browse/PIRK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621273#comment-15621273
] 

ASF GitHub Bot commented on PIRK-79:
------------------------------------

Github user wraydulany commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/115#discussion_r85686604
  
    --- Diff: src/main/java/org/apache/pirk/test/utils/BaseTests.java ---
    @@ -51,9 +51,9 @@
       public static final int dataPartitionBitSize = 8;
     
       // Selectors for domain and IP queries, queryIdentifier is the first entry for file
generation
    -  private static ArrayList<String> selectorsDomain = new ArrayList<>(
    +  public static ArrayList<String> selectorsDomain = new ArrayList<>(
           Arrays.asList("s.t.u.net", "d.e.com", "r.r.r.r", "a.b.c.com", "something.else",
"x.y.net"));
    -  private static ArrayList<String> selectorsIP = new ArrayList<>(Arrays.asList("55.55.55.55",
"5.6.7.8", "10.20.30.40", "13.14.15.16", "21.22.23.24"));
    +  public static ArrayList<String> selectorsIP = new ArrayList<>(Arrays.asList("55.55.55.55",
"5.6.7.8", "10.20.30.40", "13.14.15.16", "21.22.23.24"));
    --- End diff --
    
    Ditto.


> Allow json serialization to deserialize a queryInfo object that has only the name of
a query schema.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: PIRK-79
>                 URL: https://issues.apache.org/jira/browse/PIRK-79
>             Project: PIRK
>          Issue Type: Improvement
>          Components: Querier
>            Reporter: Walter Ray-Dulany
>            Assignee: Walter Ray-Dulany
>             Fix For: 0.3.0
>
>
> In Pirk Java serialization, when deserializing a queryinfo object, one can get the requisite
query schema by deserializing an entire serialized query schema object *OR* by reading the
name of a query schema (stored in queryType in the QueryInfo object) and querying against
a registry of known queryschemas. Currently, JSON serialization does the former, but not the
latter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message