pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-79) Allow json serialization to deserialize a queryInfo object that has only the name of a query schema.
Date Mon, 31 Oct 2016 03:40:58 GMT

    [ https://issues.apache.org/jira/browse/PIRK-79?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15621112#comment-15621112
] 

ASF GitHub Bot commented on PIRK-79:
------------------------------------

Github user jacobwil commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/115#discussion_r85682254
  
    --- Diff: src/test/java/org/apache/pirk/serialization/SerializationTest.java ---
    @@ -75,6 +94,106 @@ public void testJavaSerDe() throws Exception
         Assert.assertTrue(deserializedDummyObject.equals(dummyRecord));
       }
     
    +  @Test
    +  public void testQuerierResponseSerializationDeserialization()
    +  {
    +    testQuerierResponseSerializationDeserialization(jsonSerializer);
    +    testQuerierResponseSerializationDeserialization(javaSerializer);
    --- End diff --
    
    Is this line supposed to be here twice? If so, a comment as to why would be nice. 


> Allow json serialization to deserialize a queryInfo object that has only the name of
a query schema.
> ----------------------------------------------------------------------------------------------------
>
>                 Key: PIRK-79
>                 URL: https://issues.apache.org/jira/browse/PIRK-79
>             Project: PIRK
>          Issue Type: Improvement
>          Components: Querier
>            Reporter: Walter Ray-Dulany
>            Assignee: Walter Ray-Dulany
>             Fix For: 0.3.0
>
>
> In Pirk Java serialization, when deserializing a queryinfo object, one can get the requisite
query schema by deserializing an entire serialized query schema object *OR* by reading the
name of a query schema (stored in queryType in the QueryInfo object) and querying against
a registry of known queryschemas. Currently, JSON serialization does the former, but not the
latter.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message