Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 3BFE2200B95 for ; Tue, 13 Sep 2016 02:30:25 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 3A980160AC8; Tue, 13 Sep 2016 00:30:25 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 838C6160AB8 for ; Tue, 13 Sep 2016 02:30:24 +0200 (CEST) Received: (qmail 82221 invoked by uid 500); 13 Sep 2016 00:30:23 -0000 Mailing-List: contact commits-help@pirk.incubator.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pirk.incubator.apache.org Delivered-To: mailing list commits@pirk.incubator.apache.org Received: (qmail 82212 invoked by uid 99); 13 Sep 2016 00:30:23 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd2-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2016 00:30:23 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd2-us-west.apache.org (ASF Mail Server at spamd2-us-west.apache.org) with ESMTP id 61F701A03DC for ; Tue, 13 Sep 2016 00:30:23 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd2-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -5.446 X-Spam-Level: X-Spam-Status: No, score=-5.446 tagged_above=-999 required=6.31 tests=[KAM_LAZY_DOMAIN_SECURITY=1, RCVD_IN_DNSWL_HI=-5, RCVD_IN_MSPIKE_H3=-0.01, RCVD_IN_MSPIKE_WL=-0.01, RP_MATCHES_RCVD=-1.426] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd2-us-west.apache.org [10.40.0.9]) (amavisd-new, port 10024) with ESMTP id oDUk4HJaqaDB for ; Tue, 13 Sep 2016 00:30:22 +0000 (UTC) Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with SMTP id C66465F366 for ; Tue, 13 Sep 2016 00:30:21 +0000 (UTC) Received: (qmail 82138 invoked by uid 99); 13 Sep 2016 00:30:21 -0000 Received: from arcas.apache.org (HELO arcas) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 13 Sep 2016 00:30:20 +0000 Received: from arcas.apache.org (localhost [127.0.0.1]) by arcas (Postfix) with ESMTP id A45792C014D for ; Tue, 13 Sep 2016 00:30:20 +0000 (UTC) Date: Tue, 13 Sep 2016 00:30:20 +0000 (UTC) From: "DarinJ (JIRA)" To: commits@pirk.incubator.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Created] (PIRK-63) Generalize ResponderDriver to use accept a RespondLauncher class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Tue, 13 Sep 2016 00:30:25 -0000 DarinJ created PIRK-63: -------------------------- Summary: Generalize ResponderDriver to use accept a RespondLauncher class Key: PIRK-63 URL: https://issues.apache.org/jira/browse/PIRK-63 Project: PIRK Issue Type: Improvement Components: Responder Affects Versions: 0.1.0 Reporter: DarinJ Priority: Minor Fix For: 0.0.1 Currently as discussed on the mailing list, the ResponderDriver uses a switch statement based off a string in the CLI or properties file to determine the framework to launch. This is require a code change to the ResponderDriver for every framework added. The solution is to create a ResponderLauncher Interface which each framework overrides. {quote} public interface ResponderLauncher { public run() } {quote} To do this, we the change the string specifying the framework to the name of the class implementing ResponderLauncher i.e. SparkResponderLauncher and instantiate via reflection. -- This message was sent by Atlassian JIRA (v6.3.4#6332)