pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-53) Fix LICENSE and NOTICE Files for Release Compliance
Date Wed, 17 Aug 2016 09:00:30 GMT

    [ https://issues.apache.org/jira/browse/PIRK-53?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15424157#comment-15424157
] 

ASF GitHub Bot commented on PIRK-53:
------------------------------------

Github user tellison commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/65#discussion_r75086172
  
    --- Diff: LICENSE ---
    @@ -199,4 +199,64 @@
        distributed under the License is distributed on an "AS IS" BASIS,
        WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied.
        See the License for the specific language governing permissions and
    -   limitations under the License.
    \ No newline at end of file
    +   limitations under the License.
    +   
    +   
    +=======================================================================
    +Apache Pirk (incubating) Subcomponents:
    +
    +The Apache Pirk project contains subcomponents with separate copyright
    +notices and license terms. Your use of the source code for the these
    +subcomponents is subject to the terms and conditions of the following
    +licenses.
    +
    +
    +========================================================================
    +BSD-style licenses
    +========================================================================
    +
    +The following components are provided under a BSD-style license. See project link for
details.
    +The text of each license is also included at licenses/LICENSE-[project].txt.
    --- End diff --
    
    I don't see the ```licenses/``` directory being included in this PR?
    
    We really do need to include the actual text of the 3rd-party dependency licenses in our
source distribution.
    See  http://www.apache.org/dev/licensing-howto.html#permissive-deps.
    
    It's not quite one for _each_ of the Maven dependencies, things like Scala {compiler,
library, parser, xml} are covered by a single license.
    
    For an example, see Spark's [LICENSE](https://github.com/apache/spark/blob/master/LICENSE)
and [licenses/ directory](https://github.com/apache/spark/tree/master/licenses).


> Fix LICENSE and NOTICE Files for Release Compliance
> ---------------------------------------------------
>
>                 Key: PIRK-53
>                 URL: https://issues.apache.org/jira/browse/PIRK-53
>             Project: PIRK
>          Issue Type: Bug
>            Reporter: Ellison Anne Williams
>            Assignee: Ellison Anne Williams
>             Fix For: 0.1.0
>
>




--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message