pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-49) PrimitivePartioner does not account for locale settings
Date Fri, 12 Aug 2016 15:08:20 GMT

    [ https://issues.apache.org/jira/browse/PIRK-49?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15418970#comment-15418970
] 

ASF GitHub Bot commented on PIRK-49:
------------------------------------

GitHub user tellison opened a pull request:

    https://github.com/apache/incubator-pirk/pull/57

    [PIRK-49] PrimitivePartioner does not account for locale settings

     - Ensure bytes are always encoded in network byte ordering.
     - Remove primitive type partitioner's unhealthy obsession with byte buffers.
     - Simplify getPaddedPartitions method.
     - Enhanced tests for data partitioning.
     - Further tidy up of concrete type to interfaces.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tellison/incubator-pirk partitioner

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/57.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #57
    
----
commit 27d05ff2ea7b6343ff39274287e46e83c163c8c9
Author: Tim Ellison <t.p.ellison@gmail.com>
Date:   2016-08-12T14:40:41Z

    Enhancements to data partitioners.
    
     - Ensure bytes are always encoded in network byte ordering.
     - Remove primitive type partitioner's unhealthy obsession with byte
    buffers.
     - Simplify getPaddedPartitions method.
     - Enhanced tests for data partitioning.
     - Further tidy up of concrete type to interfaces.

commit 662ccbd1fd11545406762605f21abf6d02f840cc
Author: Tim Ellison <t.p.ellison@gmail.com>
Date:   2016-08-12T14:44:06Z

    Merge branch 'master' into partitioner

----


> PrimitivePartioner does not account for locale settings
> -------------------------------------------------------
>
>                 Key: PIRK-49
>                 URL: https://issues.apache.org/jira/browse/PIRK-49
>             Project: PIRK
>          Issue Type: Bug
>            Reporter: Tim Ellison
>            Assignee: Tim Ellison
>
> The class org.apache.pirk.schema.data.partitioner.PrimitiveTypePartitioner splits types
into parts using logic that is specific to the current locale of the runtime environment.
> In particular, it does not take account of default big endian or little endian byte ordering,
and it uses the platform default encoding for converting to and from Strings.  This is likely
to lead to data corruption when exchanging data across different machine architectures and
OS installations.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message