pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-47) Change Query name and number to a unique identifier
Date Thu, 11 Aug 2016 10:38:20 GMT

    [ https://issues.apache.org/jira/browse/PIRK-47?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15417000#comment-15417000
] 

ASF GitHub Bot commented on PIRK-47:
------------------------------------

GitHub user tellison opened a pull request:

    https://github.com/apache/incubator-pirk/pull/54

    [WIP] [PIRK-47] Change Query name and number to a unique identifier.

     - Replaced the QueryInfo 'queryName' and 'queryNum' with a single UUID
    identifier.
     - Removed queryName as a required QuerierDriverCLI option.
     - Removed the redundant reference to queryInfo from querier.
     - Removed redundant duplicate debug string in Paillier constructor.
     - Changed QueryInfo copy to clone idiom.
     - Ensure test utils closes file after reading results file.

You can merge this pull request into a Git repository by running:

    $ git pull https://github.com/tellison/incubator-pirk pirk-47

Alternatively you can review and apply these changes as the patch at:

    https://github.com/apache/incubator-pirk/pull/54.patch

To close this pull request, make a commit to your master/trunk branch
with (at least) the following in the commit message:

    This closes #54
    
----
commit 7891391b3db74a275313888e1be67d19728a8a66
Author: Tim Ellison <t.p.ellison@gmail.com>
Date:   2016-08-11T10:25:29Z

    [PIRK-47] Change Query name and number to a unique identifier.
    
     - Replaced the QueryInfo 'queryName' and 'queryNum' with a single UUID
    identifier.
     - Removed queryName as a required QuerierDriverCLI option.
     - Removed the redundant reference to queryInfo from querier.
     - Removed redundant duplicate debug string in Paillier constructor.
     - Changed QueryInfo copy to clone idiom.
     - Ensure test utils closes file after reading results file.

----


> Change Query name and number to a unique identifier
> ---------------------------------------------------
>
>                 Key: PIRK-47
>                 URL: https://issues.apache.org/jira/browse/PIRK-47
>             Project: PIRK
>          Issue Type: Improvement
>          Components: Querier
>            Reporter: Tim Ellison
>            Assignee: Tim Ellison
>
> Presently, each individual Query can be identified by a (String) name and (double) number.
These are not used by Pirk, but aid in identifying the query to the user, in debug, etc.
> The proposed improvement is to merge these into a universally unique identifier (UUID).
While the UUID may not be as readable as a user defined string, there is less opportunity
for inadvertent identity collision, and taken together with the query schema name still makes
identifying a particular query easy.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message