pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-29) User should be notified when attempting to decrypt with wrong querier.
Date Tue, 02 Aug 2016 01:08:22 GMT

    [ https://issues.apache.org/jira/browse/PIRK-29?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15403161#comment-15403161

ASF GitHub Bot commented on PIRK-29:

Github user smarthi commented on a diff in the pull request:

    --- Diff: src/main/java/org/apache/pirk/querier/wideskies/QuerierDriverCLI.java ---
    @@ -239,12 +242,19 @@ private boolean parseOptions()
           SystemConfiguration.setProperty(CERTAINTY, getOptionValue(CERTAINTY));
    -      if (!hasOption(QUERYNAME))
    +      if (!hasOption(QUERYID))
    -        logger.info("Must have the option " + QUERYNAME);
    +        logger.info("Must have the option " + QUERYID);
             return false;
    -      SystemConfiguration.setProperty(QUERYNAME, getOptionValue(QUERYNAME));
    +      // create a formatted date/time string
    +      Date date = new Date();
    +      SimpleDateFormat sdf = new SimpleDateFormat("MM.dd.yyyy_hh.mm.ss");
    +      String formattedDate = sdf.format(date);
    --- End diff --
    Could we use Java 8 LocalDateTime and DateTimFormatter APIs instead ? 

> User should be notified when attempting to decrypt with wrong querier.
> ----------------------------------------------------------------------
>                 Key: PIRK-29
>                 URL: https://issues.apache.org/jira/browse/PIRK-29
>             Project: PIRK
>          Issue Type: Improvement
>          Components: Querier
>            Reporter: Chris Harris
>            Assignee: Joseph Kovba
> Encrypting a query produces a Query and a Querier object that are saved as files.  The
Query file is then passed to the Responder and used to generate Response files, i.e. the encrypted
results of the query.  The user can then decrypt these results via the QuerierDriver after
specifying the Querier file along with the Response file.  If the user specifies an incorrect
Querier file, meaning one different than the one that was produced alongside the Query file
that was given to the driver, then decryption will produce no results.  The problem is that
the user will not know that there are no results as a result of an error, rather than that
there were no legitimate results.

This message was sent by Atlassian JIRA

View raw message