pirk-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "ASF GitHub Bot (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIRK-4) Add Streaming Implementation for Apache Storm
Date Sat, 27 Aug 2016 12:01:20 GMT

    [ https://issues.apache.org/jira/browse/PIRK-4?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=15441369#comment-15441369
] 

ASF GitHub Bot commented on PIRK-4:
-----------------------------------

Github user smarthi commented on a diff in the pull request:

    https://github.com/apache/incubator-pirk/pull/74#discussion_r76515097
  
    --- Diff: src/main/java/org/apache/pirk/responder/wideskies/ResponderProps.java ---
    @@ -90,7 +127,7 @@ static boolean validateResponderProperties()
         }
     
         String platform = SystemConfiguration.getProperty(PLATFORM).toLowerCase();
    -    if (!platform.equals("mapreduce") && !platform.equals("spark") &&
!platform.equals("standalone"))
    +    if (!platform.equals("mapreduce") && !platform.equals("spark") &&
!platform.equals("storm") && !platform.equals("standalone"))
    --- End diff --
    
    Change this to a switch stmt using ENUM - the if list is only gonna get longer with addition
of other backends and streaming and batch versions for each of them.


> Add Streaming Implementation for Apache Storm
> ---------------------------------------------
>
>                 Key: PIRK-4
>                 URL: https://issues.apache.org/jira/browse/PIRK-4
>             Project: PIRK
>          Issue Type: Task
>          Components: Responder
>            Reporter: Chris Harris
>            Assignee: Chris Harris
>
> Per the Pirk Roadmap, this is a feature to add support for Apache Storm



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message