From commits-return-38582-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Tue Aug 17 23:56:40 2021 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mxout1-ec2-va.apache.org (mxout1-ec2-va.apache.org [3.227.148.255]) by mx-eu-01.ponee.io (Postfix) with ESMTPS id C4B9D180181 for ; Wed, 18 Aug 2021 01:56:39 +0200 (CEST) Received: from mail.apache.org (mailroute1-lw-us.apache.org [207.244.88.153]) by mxout1-ec2-va.apache.org (ASF Mail Server at mxout1-ec2-va.apache.org) with SMTP id 073E53EA67 for ; Tue, 17 Aug 2021 23:56:39 +0000 (UTC) Received: (qmail 87025 invoked by uid 500); 17 Aug 2021 23:56:38 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 87016 invoked by uid 99); 17 Aug 2021 23:56:38 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Aug 2021 23:56:38 +0000 From: =?utf-8?q?GitBox?= To: commits@pinot.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bpinot=5D_ramabme_commented_on_a_change_in_pull_req?= =?utf-8?q?uest_=237300=3A_Add_debug_endpoint_to_get_minion_task_status=2E?= Message-ID: <162924459869.16310.3676754855675467369.asfpy@gitbox.apache.org> Date: Tue, 17 Aug 2021 23:56:38 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: ramabme commented on a change in pull request #7300: URL: https://github.com/apache/pinot/pull/7300#discussion_r690800073 ########## File path: pinot-controller/src/main/java/org/apache/pinot/controller/helix/core/minion/PinotHelixTaskResourceManager.java ########## @@ -427,29 +498,161 @@ private static String getTaskType(String name) { return name.split(TASK_NAME_SEPARATOR)[1]; } - public static class TaskCount { - private int _waiting; // Number of tasks waiting to be scheduled on minions - private int _error; // Number of tasks in error - private int _running; // Number of tasks currently running in minions - private int _total; // Total number of tasks in the batch + @JsonPropertyOrder({"taskState", "subTaskCount", "startTime", "executionStartTime", "subTaskInfos"}) + @JsonInclude(JsonInclude.Include.NON_NULL) + public static class TaskDebugInfo { + private String _startTime; + private String _executionStartTime; + private TaskState _taskState; + private TaskCount _subTaskCount; + private List _subTaskInfos; - public TaskCount() { + public TaskDebugInfo() { + } + + public void setStartTime(String startTime) { + _startTime = startTime; + } + + public void setExecutionStartTime(String executionStartTime) { + _executionStartTime = executionStartTime; + } + + public void setTaskState(TaskState taskState) { + _taskState = taskState; + } + + public void setSubTaskCount(TaskCount subTaskCount) { + _subTaskCount = subTaskCount; + } + + public void addSubTaskInfo(TaskPartitionDebugInfo subTaskInfo) { + if (_subTaskInfos == null) { + _subTaskInfos = new ArrayList<>(); + } + _subTaskInfos.add(subTaskInfo); + } + + public String getStartTime() { + return _startTime; + } + + public String getExecutionStartTime() { + return _executionStartTime; + } + + public TaskState getTaskState() { + return _taskState; } - public void addToWaiting(int waiting) { - _waiting += waiting; + public TaskCount getSubTaskCount() { + return _subTaskCount; } - public void addToRunning(int running) { - _running += running; + public List getSubTaskInfos() { + return _subTaskInfos; + } + } + + @JsonPropertyOrder({"taskId", "state", "startTime", "finishTime", "participant", "info", "taskConfig"}) + @JsonInclude(JsonInclude.Include.NON_NULL) + public static class TaskPartitionDebugInfo { Review comment: Renamed TaskPartitionDebugInfo to SubtaskDebugInfo -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org