pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pinot] mcvsubbu commented on a change in pull request #7296: Add github action workflow for ad-hoc compatibility test
Date Fri, 13 Aug 2021 20:20:08 GMT

mcvsubbu commented on a change in pull request #7296:
URL: https://github.com/apache/pinot/pull/7296#discussion_r688759671



##########
File path: .github/workflows/scripts/.pinot_compatibility_verifier.sh
##########
@@ -45,6 +45,6 @@ echo "</settings>">> ${SETTINGS_FILE}
 
 # PINOT_MAVEN_OPTS is used to provide additional maven options to the checkoutAndBuild.sh
command
 export PINOT_MAVEN_OPTS="-s $(pwd)/${SETTINGS_FILE}"
-compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT
+compatibility-verifier/checkoutAndBuild.sh -w $WORKING_DIR -o $OLD_COMMIT -n $NEW_COMMIT

Review comment:
       good to add a check for null of NEW_COMMIT. It is working because of a bug in `checkoutAndBuild.sh`




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message