pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [pinot] Jackie-Jiang commented on a change in pull request #7214: Introduce LIKE Operator
Date Tue, 27 Jul 2021 15:50:28 GMT

Jackie-Jiang commented on a change in pull request #7214:
URL: https://github.com/apache/pinot/pull/7214#discussion_r677583075



##########
File path: pinot-common/src/main/antlr4/org/apache/pinot/pql/parsers/PQL2.g4
##########
@@ -78,6 +78,7 @@ predicate:
   | isClause                              # IsPredicate
   | regexpLikeClause                      # RegexpLikePredicate
   | textMatchClause                       # TextMatchPredicate
+  | likeClause                            # TextMatchPredicate

Review comment:
       This parser is for PQL which is already deprecated. Let's not add new syntax to PQL.
The calcite SQL parser already supports LIKE syntax, and we just need to wire the query engine




-- 
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message