pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] samarth-gupta-traceable commented on a change in pull request #6375: make MAX_NUM_THREADS_PER_QUERY configurable for pinto server
Date Mon, 04 Jan 2021 13:08:52 GMT

samarth-gupta-traceable commented on a change in pull request #6375:
URL: https://github.com/apache/incubator-pinot/pull/6375#discussion_r551306383



##########
File path: pinot-integration-tests/src/test/java/org/apache/pinot/integration/tests/OfflineClusterIntegrationTest.java
##########
@@ -236,7 +236,7 @@ public void testRefreshTableConfigAndQueryTimeout()
       throws Exception {
     // Set timeout as 5ms so that query will timeout
     TableConfig tableConfig = getOfflineTableConfig();
-    tableConfig.setQueryConfig(new QueryConfig(5L));
+    tableConfig.setQueryConfig(new QueryConfig(5L, 2));

Review comment:
       @mayankshriv  I am not that familiar with integration tests code. There is no specific
reason to use value of 2 here. Pls suggest a reasonable value that can be used here. or I
can replace the value with `Runtime.getRuntime().availableProcessors()` thanks 




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message