pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] kishoreg commented on a change in pull request #6398: Reformat H3 index config spec
Date Fri, 01 Jan 2021 06:24:44 GMT

kishoreg commented on a change in pull request #6398:
URL: https://github.com/apache/incubator-pinot/pull/6398#discussion_r550736909



##########
File path: pinot-spi/src/main/java/org/apache/pinot/spi/config/table/H3IndexColumn.java
##########
@@ -21,30 +21,48 @@
 import com.fasterxml.jackson.annotation.JsonCreator;
 import com.fasterxml.jackson.annotation.JsonProperty;
 import com.google.common.base.Preconditions;
+import java.util.ArrayList;
 import java.util.List;
+import java.util.Map;
 import org.apache.commons.collections.CollectionUtils;
 import org.apache.pinot.spi.config.BaseJsonConfig;
 
 
-public class H3IndexConfig extends BaseJsonConfig {
+public class H3IndexColumn extends BaseJsonConfig {

Review comment:
       +1 on keeping this as a BaseJsonConfig, let's make sure we follow the same convention.
should this be H3IndexConfig or H3IndexColumn or just H3Index?

##########
File path: pinot-tools/src/main/resources/examples/batch/starbucksStores/starbucksStores_offline_table_config.json
##########
@@ -11,16 +11,18 @@
   },
   "tenants": {
   },
+  "fieldConfigList": [
+    {
+      "name": "location_st_point",
+      "encodingType":"RAW",
+      "indexType":"H3",
+      "properties": {

Review comment:
       this does not match the H3ColumnIndex as BaseConfig, right?




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message