pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] npawar commented on a change in pull request #5966: Validate timeColumnName when adding/updating schema/tableConfig
Date Thu, 10 Sep 2020 16:40:04 GMT

npawar commented on a change in pull request #5966:
URL: https://github.com/apache/incubator-pinot/pull/5966#discussion_r486484365



##########
File path: pinot-core/src/test/java/org/apache/pinot/core/util/SchemaUtilsTest.java
##########
@@ -35,6 +43,115 @@
  */
 public class SchemaUtilsTest {
 
+  private static final String TABLE_NAME = "testTable";
+  private static final String TIME_COLUMN = "timeColumn";
+
+  @Test
+  public void testCompatibilityWithTableConfig() {
+    // empty list
+    List<TableConfig> tableConfigs = new ArrayList<>();
+    Schema schema = new Schema.SchemaBuilder().setSchemaName(TABLE_NAME).build();
+    SchemaUtils.validate(schema, tableConfigs);

Review comment:
       do you mean a case where the schema becomes invalid, but we pass the test anyway because
of not having a try-catch?
   Just to be sure, I tried this out. The test fails if there's any exception in the should-pass
cases.
   Lmk if you were referring to something else.




----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message