From commits-return-19993-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Tue Jun 2 05:08:30 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 975EB1804BB for ; Tue, 2 Jun 2020 07:08:30 +0200 (CEST) Received: (qmail 18415 invoked by uid 500); 2 Jun 2020 05:08:29 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 18405 invoked by uid 99); 2 Jun 2020 05:08:28 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 02 Jun 2020 05:08:28 +0000 From: =?utf-8?q?GitBox?= To: commits@pinot.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-pinot=5D_chenboat_commented_on_pull_requ?= =?utf-8?q?est_=235478=3A_Add_a_new_table_config_field_for_peer_segment_down?= =?utf-8?q?load=2E?= Message-ID: <159107450846.10999.15647323577639571579.asfpy@gitbox.apache.org> Date: Tue, 02 Jun 2020 05:08:28 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit In-Reply-To: References: chenboat commented on pull request #5478: URL: https://github.com/apache/incubator-pinot/pull/5478#issuecomment-637276829 > Please add validation code ("Must be http or https") in TableConfigUtils.validate() thanks > Also, add more documentation on the new config variable (at least a pointer to the design doc). > Please label the PR marking it for release notes. > Make sure you add documentation on the config in gitbook (after you merge this PR) Done except that the last point about documentation. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org