From commits-return-20038-apmail-pinot-commits-archive=pinot.apache.org@pinot.apache.org Wed Jun 3 16:17:31 2020 Return-Path: X-Original-To: apmail-pinot-commits-archive@minotaur.apache.org Delivered-To: apmail-pinot-commits-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by minotaur.apache.org (Postfix) with SMTP id 44C971969F for ; Wed, 3 Jun 2020 16:17:31 +0000 (UTC) Received: (qmail 56104 invoked by uid 500); 3 Jun 2020 16:17:30 -0000 Delivered-To: apmail-pinot-commits-archive@pinot.apache.org Received: (qmail 56075 invoked by uid 500); 3 Jun 2020 16:17:30 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 56066 invoked by uid 99); 3 Jun 2020 16:17:30 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 03 Jun 2020 16:17:30 +0000 From: =?utf-8?q?GitBox?= To: commits@pinot.apache.org Subject: =?utf-8?q?=5BGitHub=5D_=5Bincubator-pinot=5D_mayankshriv_commented_on_pull_r?= =?utf-8?q?equest_=235487=3A_Add_multi-value_support_to_SegmentDumpTool?= Message-ID: <159120105056.17834.16429516626079091356.asfpy@gitbox.apache.org> Date: Wed, 03 Jun 2020 16:17:30 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit References: In-Reply-To: mayankshriv commented on pull request #5487: URL: https://github.com/apache/incubator-pinot/pull/5487#issuecomment-638302559 > @mayankshriv That's true for better code reuse. Though this PR is for a minor improvement, and I believe we could the refactoring in another PR. If you use PinotSegmentRecordReader, most of the code complexity you have in this PR will just go away, it will just become as simple as loop over records, and print values. I'll leave it up to you to decide. ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org