pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] mayankshriv commented on pull request #5487: Add multi-value support to SegmentDumpTool
Date Wed, 03 Jun 2020 16:17:30 GMT

mayankshriv commented on pull request #5487:
URL: https://github.com/apache/incubator-pinot/pull/5487#issuecomment-638302559


   > @mayankshriv That's true for better code reuse. Though this PR is for a minor improvement,
and I believe we could the refactoring in another PR.
   
   If you use PinotSegmentRecordReader, most of the code complexity you have in this PR will
just go away, it will just become as simple as loop over records, and print values. I'll leave
it up to you to decide. 


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message