pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] chenboat commented on pull request #5478: Add a new table config field for peer segment download.
Date Tue, 02 Jun 2020 05:08:28 GMT

chenboat commented on pull request #5478:
URL: https://github.com/apache/incubator-pinot/pull/5478#issuecomment-637276829


   > Please add validation code ("Must be http or https") in TableConfigUtils.validate()
thanks
   > Also, add more documentation on the new config variable (at least a pointer to the
design doc).
   > Please label the PR marking it for release notes.
   > Make sure you add documentation on the config in gitbook (after you merge this PR)
   
   Done except that the last point about documentation.


----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:
users@infra.apache.org



---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message