pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5483: Add ServerQuery to replace BrokerRequest in server execution engine
Date Tue, 02 Jun 2020 04:35:35 GMT

Jackie-Jiang commented on a change in pull request #5483:

File path: pinot-common/src/main/java/org/apache/pinot/common/request/v2/
@@ -0,0 +1,181 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.common.request.v2;
+import java.util.HashSet;
+import java.util.List;
+import java.util.Map;
+import java.util.Set;
+import org.apache.pinot.common.request.BrokerRequest;
+public class ServerQuery {

Review comment:
       This object can have some Server specific optimizations or pre-computed result, which
might not apply to Broker. For example, we don't need to compile the filter for broker. We
can add a separate BrokerQuery which only contain the information that Broker needs.
   Expression, Function are common and shared for both Broker and Server.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.

For queries about this service, please contact Infrastructure at:

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message