From commits-return-16160-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Tue Feb 11 03:34:49 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id AB283180661 for ; Tue, 11 Feb 2020 04:34:48 +0100 (CET) Received: (qmail 11349 invoked by uid 500); 11 Feb 2020 03:34:47 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 11309 invoked by uid 99); 11 Feb 2020 03:34:46 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 11 Feb 2020 03:34:46 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5040: Update Selection Query Limit with pre-configured value Message-ID: <158139208674.12372.11023434880354477370.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Tue, 11 Feb 2020 03:34:46 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit Jackie-Jiang commented on a change in pull request #5040: Update Selection Query Limit with pre-configured value URL: https://github.com/apache/incubator-pinot/pull/5040#discussion_r377433522 ########## File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java ########## @@ -166,6 +165,7 @@ public ServerType getServerType() { public static final String CONFIG_OF_BROKER_MIN_RESOURCE_PERCENT_FOR_START = "pinot.broker.startup.minResourcePercent"; public static final double DEFAULT_BROKER_MIN_RESOURCE_PERCENT_FOR_START = 100.0; + public static final String CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE = "enable.broker.query.limit.override"; Review comment: `pinot.broker.enable.query.limit.override` for consistency ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org