From commits-return-16108-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Sat Feb 8 01:50:57 2020 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id BC05418060E for ; Sat, 8 Feb 2020 02:50:56 +0100 (CET) Received: (qmail 89594 invoked by uid 500); 8 Feb 2020 01:50:56 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 89585 invoked by uid 99); 8 Feb 2020 01:50:56 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Sat, 08 Feb 2020 01:50:56 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] codecov-io edited a comment on issue #5046: Re-design the broker routing Message-ID: <158112665586.10135.17184263117820203335.gitbox@gitbox.apache.org> References: In-Reply-To: Date: Sat, 08 Feb 2020 01:50:55 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit codecov-io edited a comment on issue #5046: Re-design the broker routing URL: https://github.com/apache/incubator-pinot/pull/5046#issuecomment-581675126 # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=h1) Report > Merging [#5046](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=desc) into [master](https://codecov.io/gh/apache/incubator-pinot/commit/1f4605bcb1c84c3202e9a54e887a2638937eed28?src=pr&el=desc) will **increase** coverage by `<.01%`. > The diff coverage is `49.51%`. [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5046/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=tree) ```diff @@ Coverage Diff @@ ## master #5046 +/- ## ============================================ + Coverage 58.53% 58.54% +<.01% Complexity 12 12 ============================================ Files 1183 1195 +12 Lines 63213 63830 +617 Branches 9297 9411 +114 ============================================ + Hits 37003 37367 +364 - Misses 23501 23711 +210 - Partials 2709 2752 +43 ``` | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=tree) | Coverage Δ | Complexity Δ | | |---|---|---|---| | [...apache/pinot/broker/routing/v2/RoutingManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9Sb3V0aW5nTWFuYWdlci5qYXZh) | `0% <0%> (ø)` | `0 <0> (?)` | | | [...oker/routing/v2/timeboundary/TimeBoundaryInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi90aW1lYm91bmRhcnkvVGltZUJvdW5kYXJ5SW5mby5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh) | `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: | | [.../v2/instanceselector/BalancedInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL0JhbGFuY2VkSW5zdGFuY2VTZWxlY3Rvci5qYXZh) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...instanceselector/ReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL1JlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==) | `100% <100%> (ø)` | `0 <0> (?)` | | | [...ing/v2/segmentselector/OfflineSegmentSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50c2VsZWN0b3IvT2ZmbGluZVNlZ21lbnRTZWxlY3Rvci5qYXZh) | `16.66% <16.66%> (ø)` | `0 <0> (?)` | | | [...ing/v2/segmentselector/SegmentSelectorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50c2VsZWN0b3IvU2VnbWVudFNlbGVjdG9yRmFjdG9yeS5qYXZh) | `60% <60%> (ø)` | `0 <0> (?)` | | | [.../org/apache/pinot/common/config/RoutingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JvdXRpbmdDb25maWcuamF2YQ==) | `70% <60%> (-13.34%)` | `0 <0> (ø)` | | | [...uting/v2/segmentpruner/PartitionSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50cHJ1bmVyL1BhcnRpdGlvblNlZ21lbnRQcnVuZXIuamF2YQ==) | `64.63% <64.63%> (ø)` | `0 <0> (?)` | | | [...g/v2/instanceselector/InstanceSelectorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL0luc3RhbmNlU2VsZWN0b3JGYWN0b3J5LmphdmE=) | `75% <75%> (ø)` | `0 <0> (?)` | | | ... and [40 more](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree-more) | | ------ [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=continue). > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta) > `Δ = absolute (impact)`, `ø = not affected`, `? = missing data` > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=footer). Last update [1f4605b...094f675](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=lastupdated). Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments). ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org