pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5040: Update Selection Query Limit with pre-configured value
Date Tue, 11 Feb 2020 03:34:46 GMT
Jackie-Jiang commented on a change in pull request #5040: Update Selection Query Limit with
pre-configured value
URL: https://github.com/apache/incubator-pinot/pull/5040#discussion_r377433700
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
 ##########
 @@ -122,6 +122,9 @@ public BaseBrokerRequestHandler(Configuration config, RoutingTable routingTable,
     } else {
       _tableCache = null;
     }
+
+    _enableBrokerQueryLimitOverride = _config.getBoolean(CommonConstants.Broker.CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE,
false);
 
 Review comment:
   (nit) `CommonConstants.Broker` is already imported so you can directly use `Broker.CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE`

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message