Jackie-Jiang commented on a change in pull request #5040: Update Selection Query Limit with
pre-configured value
URL: https://github.com/apache/incubator-pinot/pull/5040#discussion_r376888445
##########
File path: pinot-common/src/main/java/org/apache/pinot/common/utils/CommonConstants.java
##########
@@ -42,7 +42,7 @@
public static final String LEAD_CONTROLLER_RESOURCE_ENABLED_KEY = "RESOURCE_ENABLED";
public static final String ENABLE_CASE_INSENSITIVE_PQL_KEY = "enable.case.insensitive.pql";
-
+ public static final String ENABLE_BROKER_QUERY_LIMIT_OVERRIDE_KEY = "enable.broker.query.limit.override";
Review comment:
Can you please move this under class `Broker` instead of `Helix`? Also, I would recommend
changing it to `CONFIG_OF_ENABLE_QUERY_LIMIT_OVERRIDE` to be consistent with other configs.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
|