pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] mcvsubbu commented on a change in pull request #5039: Close Kafka consumer before building or downloading immutable segment
Date Sat, 08 Feb 2020 15:30:22 GMT
mcvsubbu commented on a change in pull request #5039: Close Kafka consumer before building
or downloading immutable segment
URL: https://github.com/apache/incubator-pinot/pull/5039#discussion_r376715667
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/RealtimeTableDataManager.java
 ##########
 @@ -60,6 +63,11 @@
   private SegmentBuildTimeLeaseExtender _leaseExtender;
   private RealtimeSegmentStatsHistory _statsHistory;
   private final Semaphore _segmentBuildSemaphore;
+  // Maintains a map for the partitionIds and its related semaphores, which is to prevent
two different Kafka consumers
 
 Review comment:
   ```suggestion
     // Maintains a map of partitionIds to semaphores. The semaphore ensures that exactly
one PartitionConsumer
     // instance consumes from any stream partition. In some streams, it is possible that
having multiple consumers (with the same  consumer name on the same host)  consuming from
the same stream partition can lead to bugs.
   ```

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message