mcvsubbu commented on a change in pull request #5039: Close Kafka consumer before building
or downloading immutable segment
URL: https://github.com/apache/incubator-pinot/pull/5039#discussion_r376569978
##########
File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
##########
@@ -203,6 +203,8 @@ public void deleteSegmentFile() {
private final String _resourceDataDir;
private final IndexLoadingConfig _indexLoadingConfig;
private final Schema _schema;
+ private final Semaphore _partitionConsumerSemaphore;
+ private final AtomicBoolean _acquireConsumerSemaphore;
Review comment:
Can you please add a comment here as to why we need a boolean? thanks.
----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:
users@infra.apache.org
With regards,
Apache Git Services
---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org
|