pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] codecov-io edited a comment on issue #5039: Close Kafka consumer before building or downloading immutable segment
Date Sat, 08 Feb 2020 01:59:38 GMT
codecov-io edited a comment on issue #5039: Close Kafka consumer before building or downloading
immutable segment
URL: https://github.com/apache/incubator-pinot/pull/5039#issuecomment-581064679
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=h1) Report
   > Merging [#5039](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-pinot/commit/01a918779cd46a08e7893444395ea5ae9c96070d?src=pr&el=desc)
will **decrease** coverage by `0.02%`.
   > The diff coverage is `73.33%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5039/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5039      +/-   ##
   ============================================
   - Coverage     58.57%   58.55%   -0.03%     
     Complexity       12       12              
   ============================================
     Files          1181     1183       +2     
     Lines         63102    63233     +131     
     Branches       9287     9298      +11     
   ============================================
   + Hits          36965    37023      +58     
   - Misses        23418    23495      +77     
   + Partials       2719     2715       -4
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...ata/manager/realtime/RealtimeTableDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvUmVhbHRpbWVUYWJsZURhdGFNYW5hZ2VyLmphdmE=)
| `52.59% <100%> (+6.43%)` | `0 <0> (ø)` | :arrow_down: |
   | [...manager/realtime/LLRealtimeSegmentDataManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtY29yZS9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29yZS9kYXRhL21hbmFnZXIvcmVhbHRpbWUvTExSZWFsdGltZVNlZ21lbnREYXRhTWFuYWdlci5qYXZh)
| `70.85% <68.42%> (+1.2%)` | `0 <0> (ø)` | :arrow_down: |
   | [.../pinot/ingestion/jobs/SegmentPreprocessingJob.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vam9icy9TZWdtZW50UHJlcHJvY2Vzc2luZ0pvYi5qYXZh)
| `0% <0%> (-66.67%)` | `0% <0%> (ø)` | |
   | [...he/pinot/ingestion/utils/JobPreparationHelper.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vdXRpbHMvSm9iUHJlcGFyYXRpb25IZWxwZXIuamF2YQ==)
| `0% <0%> (-64.29%)` | `0% <0%> (ø)` | |
   | [...pache/pinot/ingestion/jobs/SegmentCreationJob.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vam9icy9TZWdtZW50Q3JlYXRpb25Kb2IuamF2YQ==)
| `0% <0%> (-57.15%)` | `0% <0%> (ø)` | |
   | [...not/ingestion/common/DefaultControllerRestApi.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vY29tbW9uL0RlZmF1bHRDb250cm9sbGVyUmVzdEFwaS5qYXZh)
| `0% <0%> (-41.13%)` | `0% <0%> (ø)` | |
   | [...apache/pinot/common/metrics/ValidationMetrics.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9WYWxpZGF0aW9uTWV0cmljcy5qYXZh)
| `47.45% <0%> (-28.82%)` | `0% <0%> (ø)` | |
   | [...rg/apache/pinot/ingestion/jobs/BaseSegmentJob.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vam9icy9CYXNlU2VnbWVudEpvYi5qYXZh)
| `31.03% <0%> (-27.59%)` | `0% <0%> (ø)` | |
   | [...apache/pinot/ingestion/jobs/SegmentTarPushJob.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vam9icy9TZWdtZW50VGFyUHVzaEpvYi5qYXZh)
| `68.42% <0%> (-21.06%)` | `0% <0%> (ø)` | |
   | [...org/apache/pinot/ingestion/utils/PushLocation.java](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vdXRpbHMvUHVzaExvY2F0aW9uLmphdmE=)
| `72.72% <0%> (-18.19%)` | `0% <0%> (ø)` | |
   | ... and [65 more](https://codecov.io/gh/apache/incubator-pinot/pull/5039/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=footer).
Last update [01a9187...20d82f0](https://codecov.io/gh/apache/incubator-pinot/pull/5039?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message