pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] codecov-io edited a comment on issue #5040: Update Selection Query Limit with pre-configured value
Date Fri, 07 Feb 2020 03:33:44 GMT
codecov-io edited a comment on issue #5040: Update Selection Query Limit with pre-configured
value
URL: https://github.com/apache/incubator-pinot/pull/5040#issuecomment-581079322
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=h1) Report
   > Merging [#5040](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-pinot/commit/89fec1e375ec480b47508e757974d1cdd65d2c68?src=pr&el=desc)
will **decrease** coverage by `0.13%`.
   > The diff coverage is `77.77%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5040/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=tree)
   
   ```diff
   @@             Coverage Diff              @@
   ##             master    #5040      +/-   ##
   ============================================
   - Coverage     58.69%   58.55%   -0.14%     
     Complexity       12       12              
   ============================================
     Files          1182     1183       +1     
     Lines         63130    63230     +100     
     Branches       9287     9303      +16     
   ============================================
   - Hits          37055    37026      -29     
   - Misses        23358    23488     +130     
   + Partials       2717     2716       -1
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...org/apache/pinot/common/utils/CommonConstants.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vdXRpbHMvQ29tbW9uQ29uc3RhbnRzLmphdmE=)
| `40% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [...apache/pinot/common/request/PinotQueryRequest.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9QaW5vdFF1ZXJ5UmVxdWVzdC5qYXZh)
| `60% <ø> (ø)` | `0 <0> (?)` | |
   | [...org/apache/pinot/sql/parsers/CalciteSqlParser.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9zcWwvcGFyc2Vycy9DYWxjaXRlU3FsUGFyc2VyLmphdmE=)
| `92.03% <ø> (-1.28%)` | `0 <0> (ø)` | |
   | [...ache/pinot/pql/parsers/pql2/ast/SelectAstNode.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9wcWwyL2FzdC9TZWxlY3RBc3ROb2RlLmphdmE=)
| `97.89% <ø> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../pinot/common/request/PinotQueryParserFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vcmVxdWVzdC9QaW5vdFF1ZXJ5UGFyc2VyRmFjdG9yeS5qYXZh)
| `50% <0%> (ø)` | `0 <0> (?)` | |
   | [...pql/parsers/PinotQuery2BrokerRequestConverter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9wcWwvcGFyc2Vycy9QaW5vdFF1ZXJ5MkJyb2tlclJlcXVlc3RDb252ZXJ0ZXIuamF2YQ==)
| `88.01% <100%> (+0.11%)` | `0 <0> (ø)` | :arrow_down: |
   | [...ot/controller/helix/core/util/HelixSetupUtils.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtY29udHJvbGxlci9zcmMvbWFpbi9qYXZhL29yZy9hcGFjaGUvcGlub3QvY29udHJvbGxlci9oZWxpeC9jb3JlL3V0aWwvSGVsaXhTZXR1cFV0aWxzLmphdmE=)
| `89.02% <100%> (+0.13%)` | `0 <0> (ø)` | :arrow_down: |
   | [.../pinot/broker/broker/helix/HelixBrokerStarter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvYnJva2VyL2hlbGl4L0hlbGl4QnJva2VyU3RhcnRlci5qYXZh)
| `70.39% <100%> (+0.39%)` | `0 <0> (ø)` | :arrow_down: |
   | [...roker/requesthandler/BaseBrokerRequestHandler.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcmVxdWVzdGhhbmRsZXIvQmFzZUJyb2tlclJlcXVlc3RIYW5kbGVyLmphdmE=)
| `81.86% <76.92%> (-0.19%)` | `0 <0> (ø)` | |
   | [.../pinot/ingestion/jobs/SegmentPreprocessingJob.java](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree#diff-cGlub3QtcGx1Z2lucy9waW5vdC1iYXRjaC1pbmdlc3Rpb24vdjBfZGVwcmVjYXRlZC9waW5vdC1pbmdlc3Rpb24tY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9pbmdlc3Rpb24vam9icy9TZWdtZW50UHJlcHJvY2Vzc2luZ0pvYi5qYXZh)
| `0% <0%> (-66.67%)` | `0% <0%> (ø)` | |
   | ... and [56 more](https://codecov.io/gh/apache/incubator-pinot/pull/5040/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=footer).
Last update [89fec1e...9eeeab6](https://codecov.io/gh/apache/incubator-pinot/pull/5040?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message