pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <>
Subject [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5046: Re-design the broker routing
Date Thu, 06 Feb 2020 23:59:22 GMT
Jackie-Jiang commented on a change in pull request #5046: Re-design the broker routing

 File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/v2/segmentselector/
 @@ -0,0 +1,50 @@
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+import java.util.List;
+import java.util.Set;
+import org.apache.helix.model.ExternalView;
+import org.apache.pinot.common.request.BrokerRequest;
+ * The segment selector selects the segments for the query. The segments selected should
cover the whole dataset (table)
 Review comment:
   Only LLC realtime table looks at the external view CONSUMING state to ensure only the first
CONSUMING segment for each partition getting selected to prevent overlap data. It will not
look at other states, which will be handled by the instance selector instead.

This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
For queries about this service, please contact Infrastructure at:

With regards,
Apache Git Services

To unsubscribe, e-mail:
For additional commands, e-mail:

View raw message