pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] fx19880617 commented on issue #5040: Update Selection Query Limit with pre-configured value
Date Thu, 06 Feb 2020 20:29:13 GMT
fx19880617 commented on issue #5040: Update Selection Query Limit with pre-configured value
URL: https://github.com/apache/incubator-pinot/pull/5040#issuecomment-583095773
 
 
   > > > We already have the `queryResponseLimit` which serves the same purpose and
reject queries with LIMIT or TOP higher than that, do we need another configuration for that?
   > > 
   > > 
   > > The purpose of this PR is to protect server side from getting big queries but
still return partial results.
   > > E.g. once we connect with powerbi&presto, a table scan operator by default
will send a select with high limit value.
   > 
   > In that case, we might better introduce some config indicating best-effort querying,
and override query with `queryResponseLimit`?
   
   Make sense, we can change the parameter to enable it.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message