pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] snleee commented on a change in pull request #5046: Re-design the broker routing
Date Thu, 06 Feb 2020 08:56:23 GMT
snleee commented on a change in pull request #5046: Re-design the broker routing
URL: https://github.com/apache/incubator-pinot/pull/5046#discussion_r375686120
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/routing/v2/segmentselector/SegmentSelector.java
 ##########
 @@ -0,0 +1,50 @@
+/**
+ * Licensed to the Apache Software Foundation (ASF) under one
+ * or more contributor license agreements.  See the NOTICE file
+ * distributed with this work for additional information
+ * regarding copyright ownership.  The ASF licenses this file
+ * to you under the Apache License, Version 2.0 (the
+ * "License"); you may not use this file except in compliance
+ * with the License.  You may obtain a copy of the License at
+ *
+ *   http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing,
+ * software distributed under the License is distributed on an
+ * "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY
+ * KIND, either express or implied.  See the License for the
+ * specific language governing permissions and limitations
+ * under the License.
+ */
+package org.apache.pinot.broker.routing.v2.segmentselector;
+
+import java.util.List;
+import java.util.Set;
+import org.apache.helix.model.ExternalView;
+import org.apache.pinot.common.request.BrokerRequest;
+
+
+/**
+ * The segment selector selects the segments for the query. The segments selected should
cover the whole dataset (table)
 
 Review comment:
   `The segments selected should the whole dataset (table) without overlap` is a bit vague.
This statement naturally makes me think of the selection step for merge/roll up use case where
we can have segments with duplicate data within the same table. If I look at the actual `offline,
realtime segment selector` implementation, it currently handles "OFFLINE/ONLINE/ERROR/CONSUMING"
issues, which is slightly different from `selecting whole dataset`. Current code looks more
like `filtering out invalid segments`.
   
   Also, the definition of `whole dataset` can be either `all segments from idealstate` or
`all segments in external view with at least one ONLINE` and so on.  Are we considering this
as the implementation specific issue for each type of segment selector?
   
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message