pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] snleee commented on a change in pull request #5046: Re-design the broker routing
Date Thu, 06 Feb 2020 08:56:23 GMT
snleee commented on a change in pull request #5046: Re-design the broker routing
URL: https://github.com/apache/incubator-pinot/pull/5046#discussion_r375698058
 
 

 ##########
 File path: pinot-common/src/main/java/org/apache/pinot/common/config/RoutingConfig.java
 ##########
 @@ -25,25 +25,48 @@
 
 
 public class RoutingConfig extends BaseJsonConfig {
+  public static final String PARTITION_AWARE_SEGMENT_PRUNER_TYPE = "partitionAware";
+  public static final String REPLICA_GROUP_INSTANCE_SELECTOR_TYPE = "replicaGroup";
+
+  @Deprecated
   public static final String ENABLE_DYNAMIC_COMPUTING_KEY = "enableDynamicComputing";
 
   private final String _routingTableBuilderName;
   private final Map<String, String> _routingTableBuilderOptions;
 
+  private final String _segmentPrunerType;
+  private final String _instanceSelectorType;
+
   @JsonCreator
   public RoutingConfig(@JsonProperty("routingTableBuilderName") @Nullable String routingTableBuilderName,
-      @JsonProperty("routingTableBuilderOptions") @Nullable Map<String, String> routingTableBuilderOptions)
{
+      @JsonProperty("routingTableBuilderOptions") @Nullable Map<String, String> routingTableBuilderOptions,
+      @JsonProperty("segmentPrunerType") @Nullable String segmentPrunerType,
+      @JsonProperty("instanceSelectorType") @Nullable String instanceSelectorType) {
     _routingTableBuilderName = routingTableBuilderName;
     _routingTableBuilderOptions = routingTableBuilderOptions;
+    _segmentPrunerType = segmentPrunerType;
+    _instanceSelectorType = instanceSelectorType;
   }
 
+  @Deprecated
 
 Review comment:
   Let's add `@Deprecated` with the PR that will hook this up with the real routing. Technically,
we still depend on `routingTableBuilderName`.

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message