pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] kishoreg commented on a change in pull request #5040: Update Selection Query Limit with pre-configured value
Date Wed, 05 Feb 2020 21:08:36 GMT
kishoreg commented on a change in pull request #5040: Update Selection Query Limit with pre-configured
value
URL: https://github.com/apache/incubator-pinot/pull/5040#discussion_r375507354
 
 

 ##########
 File path: pinot-broker/src/main/java/org/apache/pinot/broker/requesthandler/BaseBrokerRequestHandler.java
 ##########
 @@ -122,6 +123,9 @@ public BaseBrokerRequestHandler(Configuration config, RoutingTable routingTable,
     } else {
       _tableCache = null;
     }
+
+    PinotQueryParserFactory.MAX_QUERY_SELECTION_LIMIT = _config.getInt(CommonConstants.Helix.MAX_QUERY_SELECTION_LIMIT_KEY,
CommonConstants.Helix.DEFAULT_MAX_QUERY_SELECTION_LIMIT);
 
 Review comment:
   we dont need to set the variable in PinotQueryParserFactory. Just change the brokerrequest
using the config

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message