pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] npawar commented on a change in pull request #5039: Close Kafka consumer before building or downloading immutable segment
Date Wed, 05 Feb 2020 19:42:06 GMT
npawar commented on a change in pull request #5039: Close Kafka consumer before building or
downloading immutable segment
URL: https://github.com/apache/incubator-pinot/pull/5039#discussion_r375457574
 
 

 ##########
 File path: pinot-core/src/main/java/org/apache/pinot/core/data/manager/realtime/LLRealtimeSegmentDataManager.java
 ##########
 @@ -802,6 +803,11 @@ protected boolean commitSegment(String controllerVipUrl, boolean isSplitCommit)
   }
 
   protected boolean buildSegmentAndReplace() {
+    if (!(closePartitionLevelConsumer() && closeStreamMetadataProvider())) {
+      return false;
 
 Review comment:
   I think this could result in no segment being built. My guess is that is we get an exception
when closing the partitionLevelConsumer or the streamMetadataConsumer, it'll likely be a stream
issue, and we'll get exceptions across all partitions, and no one will build the segment.

   Wdyt?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message