pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] Jackie-Jiang commented on a change in pull request #5035: Adding backward compatible classname mapping from old plugins classname
Date Tue, 04 Feb 2020 23:10:39 GMT
Jackie-Jiang commented on a change in pull request #5035: Adding backward compatible classname
mapping from old plugins classname
URL: https://github.com/apache/incubator-pinot/pull/5035#discussion_r374974362
 
 

 ##########
 File path: pinot-spi/src/main/java/org/apache/pinot/spi/plugin/PluginManager.java
 ##########
 @@ -45,6 +45,33 @@
   private static final String JAR_FILE_EXTENSION = "jar";
   private static PluginManager PLUGIN_MANAGER = new PluginManager();
 
+  // For backward compatibility, this map holds a mapping from old plugins class name to
its new class name.
+  static final Map<String, String> PLUGINS_BACKWARD_COMPATIBLE_CLASS_NAME_MAP = new
HashMap<String, String>(){
 
 Review comment:
   Recommend making it private and test with the old class name in the test?

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message