pinot-commits mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From GitBox <...@apache.org>
Subject [GitHub] [incubator-pinot] codecov-io edited a comment on issue #5046: Re-design the broker routing
Date Mon, 03 Feb 2020 23:52:51 GMT
codecov-io edited a comment on issue #5046: Re-design the broker routing
URL: https://github.com/apache/incubator-pinot/pull/5046#issuecomment-581675126
 
 
   # [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=h1) Report
   > Merging [#5046](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=desc)
into [master](https://codecov.io/gh/apache/incubator-pinot/commit/f5fe4af026824c2096559c62dfaac3ef52542b79?src=pr&el=desc)
will **increase** coverage by `18.98%`.
   > The diff coverage is `50.97%`.
   
   [![Impacted file tree graph](https://codecov.io/gh/apache/incubator-pinot/pull/5046/graphs/tree.svg?width=650&token=4ibza2ugkz&height=150&src=pr)](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=tree)
   
   ```diff
   @@              Coverage Diff              @@
   ##             master    #5046       +/-   ##
   =============================================
   + Coverage     39.63%   58.61%   +18.98%     
   - Complexity        0       12       +12     
   =============================================
     Files          1182     1195       +13     
     Lines         63135    63752      +617     
     Branches       9287     9397      +110     
   =============================================
   + Hits          25022    37370    +12348     
   + Misses        35935    23633    -12302     
   - Partials       2178     2749      +571
   ```
   
   
   | [Impacted Files](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=tree)
| Coverage Δ | Complexity Δ | |
   |---|---|---|---|
   | [...apache/pinot/broker/routing/v2/RoutingManager.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9Sb3V0aW5nTWFuYWdlci5qYXZh)
| `0% <0%> (ø)` | `0 <0> (?)` | |
   | [...oker/routing/v2/timeboundary/TimeBoundaryInfo.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi90aW1lYm91bmRhcnkvVGltZUJvdW5kYXJ5SW5mby5qYXZh)
| `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...a/org/apache/pinot/common/metrics/BrokerMeter.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vbWV0cmljcy9Ccm9rZXJNZXRlci5qYXZh)
| `100% <100%> (ø)` | `0 <0> (ø)` | :arrow_down: |
   | [.../v2/instanceselector/BalancedInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL0JhbGFuY2VkSW5zdGFuY2VTZWxlY3Rvci5qYXZh)
| `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...ing/v2/segmentselector/OfflineSegmentSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50c2VsZWN0b3IvT2ZmbGluZVNlZ21lbnRTZWxlY3Rvci5qYXZh)
| `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...instanceselector/ReplicaGroupInstanceSelector.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9pbnN0YW5jZXNlbGVjdG9yL1JlcGxpY2FHcm91cEluc3RhbmNlU2VsZWN0b3IuamF2YQ==)
| `100% <100%> (ø)` | `0 <0> (?)` | |
   | [...er/routing/v2/segmentpruner/NoOpSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50cHJ1bmVyL05vT3BTZWdtZW50UHJ1bmVyLmphdmE=)
| `20% <20%> (ø)` | `0 <0> (?)` | |
   | [.../org/apache/pinot/common/config/RoutingConfig.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtY29tbW9uL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9jb21tb24vY29uZmlnL1JvdXRpbmdDb25maWcuamF2YQ==)
| `70% <60%> (+70%)` | `0 <0> (ø)` | :arrow_down: |
   | [...ing/v2/segmentselector/SegmentSelectorFactory.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50c2VsZWN0b3IvU2VnbWVudFNlbGVjdG9yRmFjdG9yeS5qYXZh)
| `60% <60%> (ø)` | `0 <0> (?)` | |
   | [.../v2/segmentpruner/PartitionAwareSegmentPruner.java](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree#diff-cGlub3QtYnJva2VyL3NyYy9tYWluL2phdmEvb3JnL2FwYWNoZS9waW5vdC9icm9rZXIvcm91dGluZy92Mi9zZWdtZW50cHJ1bmVyL1BhcnRpdGlvbkF3YXJlU2VnbWVudFBydW5lci5qYXZh)
| `64.63% <64.63%> (ø)` | `0 <0> (?)` | |
   | ... and [598 more](https://codecov.io/gh/apache/incubator-pinot/pull/5046/diff?src=pr&el=tree-more)
| |
   
   ------
   
   [Continue to review full report at Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=continue).
   > **Legend** - [Click here to learn more](https://docs.codecov.io/docs/codecov-delta)
   > `Δ = absolute <relative> (impact)`, `ø = not affected`, `? = missing data`
   > Powered by [Codecov](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=footer).
Last update [f5fe4af...e60e9f1](https://codecov.io/gh/apache/incubator-pinot/pull/5046?src=pr&el=lastupdated).
Read the [comment docs](https://docs.codecov.io/docs/pull-request-comments).
   

----------------------------------------------------------------
This is an automated message from the Apache Git Service.
To respond to the message, please log on to GitHub and use the
URL above to go to the specific comment.
 
For queries about this service, please contact Infrastructure at:
users@infra.apache.org


With regards,
Apache Git Services

---------------------------------------------------------------------
To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org
For additional commands, e-mail: commits-help@pinot.apache.org


Mime
View raw message