From commits-return-14400-archive-asf-public=cust-asf.ponee.io@pinot.apache.org Tue Dec 17 23:20:30 2019 Return-Path: X-Original-To: archive-asf-public@cust-asf.ponee.io Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [207.244.88.153]) by mx-eu-01.ponee.io (Postfix) with SMTP id 629F3180607 for ; Wed, 18 Dec 2019 00:20:30 +0100 (CET) Received: (qmail 91405 invoked by uid 500); 17 Dec 2019 23:20:29 -0000 Mailing-List: contact commits-help@pinot.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pinot.apache.org Delivered-To: mailing list commits@pinot.apache.org Received: (qmail 91396 invoked by uid 99); 17 Dec 2019 23:20:29 -0000 Received: from ec2-52-202-80-70.compute-1.amazonaws.com (HELO gitbox.apache.org) (52.202.80.70) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 17 Dec 2019 23:20:29 +0000 From: GitBox To: commits@pinot.apache.org Subject: [GitHub] [incubator-pinot] kishoreg opened a new pull request #4937: changing pinot-avro dependency scope to test from compile Message-ID: <157662482969.32475.12209340021136807246.gitbox@gitbox.apache.org> Date: Tue, 17 Dec 2019 23:20:29 -0000 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 8bit kishoreg opened a new pull request #4937: changing pinot-avro dependency scope to test from compile URL: https://github.com/apache/incubator-pinot/pull/4937 SegmentGenerationConfig depended on AvroUtils. Removed the usage and cleaned up the dependency. After this change, pinot modules dont depend on any specific implementations at compile time. We have some dependencies at test scope. ![Screen Shot 2019-12-17 at 3 18 20 PM](https://user-images.githubusercontent.com/850791/71042405-7d968100-20e0-11ea-833a-a5dc7bded796.png) ![Screen Shot 2019-12-17 at 3 18 13 PM](https://user-images.githubusercontent.com/850791/71042412-825b3500-20e0-11ea-817d-af374ecd690f.png) ---------------------------------------------------------------- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. For queries about this service, please contact Infrastructure at: users@infra.apache.org With regards, Apache Git Services --------------------------------------------------------------------- To unsubscribe, e-mail: commits-unsubscribe@pinot.apache.org For additional commands, e-mail: commits-help@pinot.apache.org