pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohini Palaniswamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-5201) Null handling on FLATTEN
Date Mon, 30 Oct 2017 17:48:00 GMT

    [ https://issues.apache.org/jira/browse/PIG-5201?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16225411#comment-16225411
] 

Rohini Palaniswamy commented on PIG-5201:
-----------------------------------------

1) 
bq. Took a look but I'm already afraid of introducing a regression with this current change.
Prefer not to touch other places if not necessary.
  It should be a simple change. Don't see any cause for concern of regression. I am asking
this because, currently isToBeFlattenedArray is being checked three times before going to
the case of not FLATTEN while it should be done only once. This is very inefficient as the
number of flatten compared to fields without flatten in a foreach statement is very less.
Also there are many users with 100+ columns in a foreach statement and it will be bad for
those cases.

2) Doc minor issues
 some null Tuples -> some null tuples
Flatten operataor -> FLATTEN operator  (capitalize + typo in operator)




> Null handling on FLATTEN
> ------------------------
>
>                 Key: PIG-5201
>                 URL: https://issues.apache.org/jira/browse/PIG-5201
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Koji Noguchi
>            Assignee: Koji Noguchi
>             Fix For: 0.18.0
>
>         Attachments: pig-5201-v00-testonly.patch, pig-5201-v01.patch, pig-5201-v02.patch,
pig-5201-v03.patch, pig-5201-v04.patch, pig-5201-v05.patch
>
>
> Sometimes, FLATTEN(null) or FLATTEN(bag-with-null) seem to produce incorrect results.
> Test code/script to follow.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message