pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Eirik Y. Øra (JIRA) <j...@apache.org>
Subject [jira] [Commented] (PIG-3864) ToDate(userstring, format, timezone) computes DateTime with strange handling of Daylight Saving Time with location based timezones
Date Tue, 26 Sep 2017 22:28:00 GMT

    [ https://issues.apache.org/jira/browse/PIG-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181685#comment-16181685
] 

Eirik Y. Øra commented on PIG-3864:
-----------------------------------

I'm not in a situation where I can test this now (not on that project with Pig
installed), but I read the patch and it seems good as also now the unit test
handles the case I had described. Thanks.  





On Tue, Sep 26, 2017 9:33 PM, Rohini Palaniswamy (JIRA) jira@apache.org  wrote:



  [
https://issues.apache.org/jira/browse/PIG-3864?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=16181402#comment-16181402
] 




Rohini Palaniswamy commented on PIG-3864:

-----------------------------------------




[~szita],

  Can you review this one? You would be more familiar with the different forms
of specifying the timezone after PIG-4748.




of Daylight Saving Time with location based timezones

----------------------------------------------------------------------------------------------------------------------------------














handling of the timezone offset is based on whether the timezone is currently in
daylight saving and not based on whether the timestamp is in daylight saving
time or not.



HH:mm:ss.SSSZ', 'Europe/Berlin') AS Timestamp;









noted in the documentation.










--

This message was sent by Atlassian JIRA

(v6.4.14#64029)


> ToDate(userstring, format, timezone) computes DateTime with strange handling of Daylight
Saving Time with location based timezones
> ----------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: PIG-3864
>                 URL: https://issues.apache.org/jira/browse/PIG-3864
>             Project: Pig
>          Issue Type: Bug
>    Affects Versions: 0.12.0, 0.11.1
>            Reporter: Frederic Schmaljohann
>            Assignee: Daniel Dai
>             Fix For: 0.18.0
>
>         Attachments: PIG-3864-1.patch
>
>
> When using ToDate with a location based timezone (e.g. "Europe/Berlin") the handling
of the timezone offset is based on whether the timezone is currently in daylight saving and
not based on whether the timestamp is in daylight saving time or not.
> Example:
> {noformat}
> B = FOREACH A GENERATE ToDate('2014-02-02 18:00:00.000Z', 'yyyy-MM-dd HH:mm:ss.SSSZ',
'Europe/Berlin') AS Timestamp;
> {noformat}
> This yields 
> {noformat}2014-02-02 20:00:00.000+02{noformat}
> when called during daylight saving in Europe/Berlin although I would expect 
> {noformat}2014-02-02 19:00:00.000+01{noformat}
> During standard time In Europe/Berlin, the above call yields 
> {noformat}2014-02-02 19:00:00.000+01{noformat}
> In Europe/Berlin DST started on March 30th, 2014.
> This seems pretty strange to me. If it is on purpose it should at least be noted in the
documentation.



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message