Return-Path: X-Original-To: archive-asf-public-internal@cust-asf2.ponee.io Delivered-To: archive-asf-public-internal@cust-asf2.ponee.io Received: from cust-asf.ponee.io (cust-asf.ponee.io [163.172.22.183]) by cust-asf2.ponee.io (Postfix) with ESMTP id 30A3C200CE0 for ; Fri, 11 Aug 2017 07:27:09 +0200 (CEST) Received: by cust-asf.ponee.io (Postfix) id 2F35016CD6D; Fri, 11 Aug 2017 05:27:09 +0000 (UTC) Delivered-To: archive-asf-public@cust-asf.ponee.io Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by cust-asf.ponee.io (Postfix) with SMTP id 749BA16CD6A for ; Fri, 11 Aug 2017 07:27:08 +0200 (CEST) Received: (qmail 16837 invoked by uid 500); 11 Aug 2017 05:27:07 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 16826 invoked by uid 500); 11 Aug 2017 05:27:07 -0000 Delivered-To: apmail-hadoop-pig-dev@hadoop.apache.org Received: (qmail 16823 invoked by uid 99); 11 Aug 2017 05:27:07 -0000 Received: from pnap-us-west-generic-nat.apache.org (HELO spamd1-us-west.apache.org) (209.188.14.142) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 11 Aug 2017 05:27:07 +0000 Received: from localhost (localhost [127.0.0.1]) by spamd1-us-west.apache.org (ASF Mail Server at spamd1-us-west.apache.org) with ESMTP id 26507C0122 for ; Fri, 11 Aug 2017 05:27:06 +0000 (UTC) X-Virus-Scanned: Debian amavisd-new at spamd1-us-west.apache.org X-Spam-Flag: NO X-Spam-Score: -100.002 X-Spam-Level: X-Spam-Status: No, score=-100.002 tagged_above=-999 required=6.31 tests=[RP_MATCHES_RCVD=-0.001, SPF_PASS=-0.001, USER_IN_WHITELIST=-100] autolearn=disabled Received: from mx1-lw-eu.apache.org ([10.40.0.8]) by localhost (spamd1-us-west.apache.org [10.40.0.7]) (amavisd-new, port 10024) with ESMTP id HLbyYre-RWFP for ; Fri, 11 Aug 2017 05:27:05 +0000 (UTC) Received: from mailrelay1-us-west.apache.org (mailrelay1-us-west.apache.org [209.188.14.139]) by mx1-lw-eu.apache.org (ASF Mail Server at mx1-lw-eu.apache.org) with ESMTP id C339A5F6C2 for ; Fri, 11 Aug 2017 05:27:04 +0000 (UTC) Received: from jira-lw-us.apache.org (unknown [207.244.88.139]) by mailrelay1-us-west.apache.org (ASF Mail Server at mailrelay1-us-west.apache.org) with ESMTP id 9016CE07DD for ; Fri, 11 Aug 2017 05:27:03 +0000 (UTC) Received: from jira-lw-us.apache.org (localhost [127.0.0.1]) by jira-lw-us.apache.org (ASF Mail Server at jira-lw-us.apache.org) with ESMTP id 9C47B23FFD for ; Fri, 11 Aug 2017 05:27:02 +0000 (UTC) Date: Fri, 11 Aug 2017 05:27:02 +0000 (UTC) From: "Rohini Palaniswamy (JIRA)" To: pig-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Updated] (PIG-5288) Improve performance of PigTextRawBytesComparator MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 archived-at: Fri, 11 Aug 2017 05:27:09 -0000 [ https://issues.apache.org/jira/browse/PIG-5288?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ] Rohini Palaniswamy updated PIG-5288: ------------------------------------ Attachment: PIG-5288-1.patch > Improve performance of PigTextRawBytesComparator > ------------------------------------------------ > > Key: PIG-5288 > URL: https://issues.apache.org/jira/browse/PIG-5288 > Project: Pig > Issue Type: Improvement > Reporter: Rohini Palaniswamy > Assignee: Rohini Palaniswamy > Fix For: 0.18.0 > > Attachments: PIG-5288-1.patch > > > Came across this stacktrace for a group by when investigating a different performance issue. > {code} > "TezChild" #22 daemon prio=5 os_prio=0 tid=0x00007fa935495000 nid=0x7c3e runnable [0x00007fa91d354000] > java.lang.Thread.State: RUNNABLE > at sun.nio.cs.UTF_8$Decoder.decodeLoop(UTF_8.java:412) > at java.nio.charset.CharsetDecoder.decode(CharsetDecoder.java:579) > at java.nio.charset.CharsetDecoder.decode(CharsetDecoder.java:802) > at org.apache.hadoop.io.Text.decode(Text.java:412) > at org.apache.hadoop.io.Text.decode(Text.java:389) > at org.apache.hadoop.io.Text.toString(Text.java:280) > at org.apache.pig.impl.io.NullableText.getValueAsPigType(NullableText.java:46) > at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.PigTextRawComparator.compare(PigTextRawComparator.java:95) > at org.apache.tez.runtime.library.common.ValuesIterator.readNextKey(ValuesIterator.java:188) > at org.apache.tez.runtime.library.common.ValuesIterator.access$300(ValuesIterator.java:47) > at org.apache.tez.runtime.library.common.ValuesIterator$1$1.next(ValuesIterator.java:143) > at org.apache.pig.backend.hadoop.executionengine.tez.plan.operator.POShuffleTezLoad.getNextTuple(POShuffleTezLoad.java:218) > {code} > Conversion to String and comparing is a wastage (result of extending from PigTextRawBytesComparator which is used in sorting). PigCharArrayWritableComparator which is the equivalent used in mapreduce does not. It directly compares it as a Text. -- This message was sent by Atlassian JIRA (v6.4.14#64029)