pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] [Resolved] (PIG-5293) Suspicious code as missing `this' for a member
Date Wed, 23 Aug 2017 04:56:00 GMT

     [ https://issues.apache.org/jira/browse/PIG-5293?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Dai resolved PIG-5293.
-----------------------------
       Resolution: Fixed
     Hadoop Flags: Reviewed
    Fix Version/s: 0.18.0

Patch committed to trunk. Thanks [~lifove]!

> Suspicious code as missing `this' for a member
> ----------------------------------------------
>
>                 Key: PIG-5293
>                 URL: https://issues.apache.org/jira/browse/PIG-5293
>             Project: Pig
>          Issue Type: Bug
>            Reporter: JC
>            Assignee: JC
>             Fix For: 0.18.0
>
>
> Hi
> In a recent github mirror, I've found suspicious code.
> Branch: trunk
> Path: src/org/apache/pig/pen/util/ExampleTuple.java
> {code:java}
> ...
>  39     Tuple t = null;
> ...
> 110     @Override
> 111     public void reference(Tuple t) {
> 112         t.reference(t);
> 113     }
> {code}
> In Line 112, `t.reference' should be `this.t.reference'? This might be just a trivial
thing as the class name as ExampleTuple. But I wanted to report just in case.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.14#64029)

Mime
View raw message