pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Daniel Dai (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (PIG-4942) Fix mvn-install ant target
Date Sun, 17 Jul 2016 07:48:20 GMT

     [ https://issues.apache.org/jira/browse/PIG-4942?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Daniel Dai updated PIG-4942:
----------------------------
    Attachment: PIG-4942.3.patch

Yes mvn-install is broken, we shall fix it. Since mvn-deploy does more than mvn-install, and
mvn-deploy is working, the fix can be simpler. We can just follow mvn-deploy to fix mvn-install.
Attach PIG-4942.3.patch, can you check if it works for you?

This fix shall only go to 0.16 branch, since we are dropping hadoop-1 support in 0.17, build
and release script will be much simplified.

> Fix mvn-install ant target
> --------------------------
>
>                 Key: PIG-4942
>                 URL: https://issues.apache.org/jira/browse/PIG-4942
>             Project: Pig
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 0.16.0
>            Reporter: Peter Slawski
>             Fix For: 0.16.1
>
>         Attachments: PIG-4942.1.patch, PIG-4942.2.patch, PIG-4942.3.patch
>
>
> The mvn-install ant target which allows pig artifacts to be placed in the local repository
became broken by PIG-4499 in Pig 0.15. That patch removed the mvn-jar target which the mvn-install
target had dependent on. Instead, the jar-h12 target was used as a replacement. However, this
target is insufficient as it does not move built jars to their expected output locations and
does not handle well the case where we are building Pig only for Hadoop 2 via the {{-Dhadoopversion=23}}
option. 
> There is an important detail to make note. The {{jar-h12}} target uses propertyreset
scripts to change the hadoopversion property before it calls ant targets to change the behavior
of the ant targets. These propertyreset scripts do nothing when the {{-Dhadoopversion}} option
is provided through the command line. This is because ant does not allow overwriting user
properties.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message