pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From Pallavi Rao <pallavi....@inmobi.com>
Subject Re: Review Request 43044: PIG-4766 Ensure GroupBy is optimized for all algebraic Operations
Date Fri, 05 Feb 2016 04:25:51 GMT

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/43044/
-----------------------------------------------------------

(Updated Feb. 5, 2016, 4:25 a.m.)


Review request for pig, Xianda Ke, liyun zhang, Mohit Sabharwal, and Xuefu Zhang.


Changes
-------

Rebased patch


Bugs: PIG-4766
    https://issues.apache.org/jira/browse/PIG-4766


Repository: pig-git


Description
-------

PIG-4709 introduced Combiner optimization for Group By. However, the patch did not handle
cases where constant/conditional expressions were used. It also did not handle limit.

This patch is to address those gaps.


Diffs (updated)
-----

  src/org/apache/pig/backend/hadoop/executionengine/physicalLayer/expressionOperators/PORelationToExprProject.java
5fb49e2 
  src/org/apache/pig/backend/hadoop/executionengine/spark/converter/ReduceByConverter.java
d4b521a 
  src/org/apache/pig/backend/hadoop/executionengine/spark/optimizer/CombinerOptimizer.java
a05d009 
  src/org/apache/pig/backend/hadoop/executionengine/util/CombinerOptimizerUtil.java 5c0919f

  test/org/apache/pig/newplan/logical/relational/TestLocationInPhysicalPlan.java 0e45434 
  test/org/apache/pig/test/TestCombiner.java b2e81ac 

Diff: https://reviews.apache.org/r/43044/diff/


Testing
-------

With this patch, all tests in TestCombiner pass.


Thanks,

Pallavi Rao


Mime
  • Unnamed multipart/alternative (inline, None, 0 bytes)
View raw message