pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohini Palaniswamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-4670) Embedded Python scripts still parse line by line
Date Fri, 09 Oct 2015 11:10:27 GMT

    [ https://issues.apache.org/jira/browse/PIG-4670?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14950218#comment-14950218
] 

Rohini Palaniswamy commented on PIG-4670:
-----------------------------------------

I ended up changing code for describe and explain as well earlier which caused the query to
execute. So reverted changes in that case back to what it was. Basically it turns on the batch,
but called parseStopOnError(true) so that executeBatch() is not done in parseStopOnError.


{code}
if (!sameBatch) {
                executeBatch();
            }
{code}

Additionally added pigServer.setSkipParseInRegisterForBatch(true); to skip parsing while registering
query as dumpSchema() was calling parseQuery again.

> Embedded Python scripts still parse line by line
> ------------------------------------------------
>
>                 Key: PIG-4670
>                 URL: https://issues.apache.org/jira/browse/PIG-4670
>             Project: Pig
>          Issue Type: Bug
>            Reporter: Rohini Palaniswamy
>            Assignee: Rohini Palaniswamy
>             Fix For: 0.16.0
>
>         Attachments: PIG-4670-1.patch, PIG-4670-2.patch, PIG-4670-fix-e2e-failures-nowhitespacechange.patch,
PIG-4670-fix-e2e-failures.patch
>
>
> PIG-3204 fixed pig script parsing to parse in batches instead of line by line. But the
fix in BoundScript is not right and it is still parsing line by line. That makes parsing take
long time for very large pig scripts using PigStorage when there is no schema file stored
and without -noschema as it tries to find the schema file lots of times.
> It should be grunt.parseStopOnError(false); instead of grunt.parseStopOnError(true);
to make it parse statements in batch.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message