Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 4B2D517B92 for ; Wed, 4 Feb 2015 21:48:34 +0000 (UTC) Received: (qmail 70435 invoked by uid 500); 4 Feb 2015 21:48:35 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 70375 invoked by uid 500); 4 Feb 2015 21:48:35 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 70363 invoked by uid 500); 4 Feb 2015 21:48:35 -0000 Delivered-To: apmail-hadoop-pig-dev@hadoop.apache.org Received: (qmail 70360 invoked by uid 99); 4 Feb 2015 21:48:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 04 Feb 2015 21:48:35 +0000 Date: Wed, 4 Feb 2015 21:48:35 +0000 (UTC) From: "Rohini Palaniswamy (JIRA)" To: pig-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PIG-4410) Fix testRankWithEmptyReduce in tez mode MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PIG-4410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14306031#comment-14306031 ] Rohini Palaniswamy commented on PIG-4410: ----------------------------------------- +1 > Fix testRankWithEmptyReduce in tez mode > --------------------------------------- > > Key: PIG-4410 > URL: https://issues.apache.org/jira/browse/PIG-4410 > Project: Pig > Issue Type: Bug > Components: tez > Reporter: Daniel Dai > Assignee: Daniel Dai > Fix For: 0.15.0 > > Attachments: PIG-4410-1.patch > > > testRankWithEmptyReduce added in PIG-4392 failed in tez mode. The reason is POReservoirSample produce more sample than necessary. In particular, if the input of the vertex is empty, it produces a fake tuple which does not have the original data, but a marked field plus 0 rowNum. That cause the WeightedRangePartitioner fail: > {code} > Caused by: java.lang.ClassCastException: java.lang.String cannot be cast to java.lang.Integer > at org.apache.pig.backend.hadoop.HDataType.getWritableComparableTypes(HDataType.java:115) > at org.apache.pig.backend.hadoop.executionengine.mapReduceLayer.partitioners.WeightedRangePartitioner.getPigNullableWritable(WeightedRangePartitioner.java:192) > {code} > Another issue I found is GetMemNumRows, I erroneously add the size of mark tuple, which make the size estimation inaccurate. I put the fix in the same patch. -- This message was sent by Atlassian JIRA (v6.3.4#6332)