Return-Path: X-Original-To: apmail-pig-dev-archive@www.apache.org Delivered-To: apmail-pig-dev-archive@www.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id C37D51744D for ; Fri, 23 Jan 2015 13:22:41 +0000 (UTC) Received: (qmail 14151 invoked by uid 500); 23 Jan 2015 13:22:35 -0000 Delivered-To: apmail-pig-dev-archive@pig.apache.org Received: (qmail 14105 invoked by uid 500); 23 Jan 2015 13:22:35 -0000 Mailing-List: contact dev-help@pig.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: dev@pig.apache.org Delivered-To: mailing list dev@pig.apache.org Received: (qmail 14065 invoked by uid 500); 23 Jan 2015 13:22:35 -0000 Delivered-To: apmail-hadoop-pig-dev@hadoop.apache.org Received: (qmail 14057 invoked by uid 99); 23 Jan 2015 13:22:35 -0000 Received: from arcas.apache.org (HELO arcas.apache.org) (140.211.11.28) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 23 Jan 2015 13:22:35 +0000 Date: Fri, 23 Jan 2015 13:22:35 +0000 (UTC) From: "Rohini Palaniswamy (JIRA)" To: pig-dev@hadoop.apache.org Message-ID: In-Reply-To: References: Subject: [jira] [Commented] (PIG-3615) Update the way that JsonLoader/JsonStorage deal with BigDecimal MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/PIG-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289228#comment-14289228 ] Rohini Palaniswamy commented on PIG-3615: ----------------------------------------- Sorry. My bad. I was just looking at the commits and went by the code in the first commit. I should have bothered to read through the comments in the jira and find the second commit. Do you still want to go with the --encode-bigdecimal-as-string for JsonStorage? > Update the way that JsonLoader/JsonStorage deal with BigDecimal > --------------------------------------------------------------- > > Key: PIG-3615 > URL: https://issues.apache.org/jira/browse/PIG-3615 > Project: Pig > Issue Type: Improvement > Affects Versions: 0.12.0 > Reporter: Erik Selin > Assignee: Erik Selin > Priority: Minor > Fix For: 0.15.0 > > Attachments: PIG-3615.patch, bugPig-3615.patch > > > It's a common (and good) convention to quote fixed point numbers when storing them as json. The reason being that majority of json libraries will implicitly load any number value as a floating point number and if you care about data integrity this will make you very sad. > This update makes JsonLoader able to load BigDecimal values from quoted values (the old jackson library that we're using doesn't support this through the current approach) as well as making JsonStorage store BigDecimal values as quoted strings. -- This message was sent by Atlassian JIRA (v6.3.4#6332)