pig-dev mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Rohini Palaniswamy (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (PIG-3615) Update the way that JsonLoader/JsonStorage deal with BigDecimal
Date Fri, 23 Jan 2015 13:22:35 GMT

    [ https://issues.apache.org/jira/browse/PIG-3615?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=14289228#comment-14289228
] 

Rohini Palaniswamy commented on PIG-3615:
-----------------------------------------

Sorry. My bad. I was just looking at the commits and went by the code in the first commit.
I should have bothered to read through the comments in the jira and find the second commit.
 Do you still want to go with the --encode-bigdecimal-as-string for JsonStorage?

> Update the way that JsonLoader/JsonStorage deal with BigDecimal
> ---------------------------------------------------------------
>
>                 Key: PIG-3615
>                 URL: https://issues.apache.org/jira/browse/PIG-3615
>             Project: Pig
>          Issue Type: Improvement
>    Affects Versions: 0.12.0
>            Reporter: Erik Selin
>            Assignee: Erik Selin
>            Priority: Minor
>             Fix For: 0.15.0
>
>         Attachments: PIG-3615.patch, bugPig-3615.patch
>
>
> It's a common (and good) convention to quote fixed point numbers when storing them as
json. The reason being that majority of json libraries will implicitly load any number value
as a floating point number and if you care about data integrity this will make you very sad.
> This update makes JsonLoader able to load BigDecimal values from quoted values (the old
jackson library that we're using doesn't support this through the current approach) as well
as making JsonStorage store BigDecimal values as quoted strings.



--
This message was sent by Atlassian JIRA
(v6.3.4#6332)

Mime
View raw message